Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permission for Moondial and unrecognized SFX #3027

Open
wants to merge 6 commits into
base: general-devel
Choose a base branch
from
Open

Add permission for Moondial and unrecognized SFX #3027

wants to merge 6 commits into from

Conversation

Arthri
Copy link
Contributor

@Arthri Arthri commented Apr 9, 2024

  • Added explicit cases for cases 2, 4, and 5 of Packet 51. These are harmless and so are approved with no checks
  • Added a handler for case 6 or Enchanted Moondial of Packet 51. Added a new permission, tshock.world.time.usemoondial, to regulate Enchanted Moondial's use
  • Added a default case for Packet 51 which instead checks for the tshock.specialeffects.{type} permission if TShock does not recognize the case yet

@Arthri
Copy link
Contributor Author

Arthri commented Apr 23, 2024

Fixing DisableDungeonGuardian requires a non-trivial amount of work, so I've decided not to do it in this PR. The Dungeon Guardian is spawned by the server, deep inside the NPC.SpawnNPC method, which would require IL patching and all the strings attached with that

ghost
ghost approved these changes Apr 29, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Arthri